fix: merge from dev to main#614
Merged
Merged
Conversation
Created a new document for Sample questions
Added sample questions and scenarios for users to explore various functionalities in the app.
Updated sample prompts for various scenarios to enhance clarity and consistency.
Added a 'Next Steps' section with sample questions after deployment instructions.
fix: added e2e testing in validate non waf pipeline and fixed WAF deployment pipeline
Removed the instruction to provide a plan to increase satisfaction.
Updated instructions for team selection and scenarios, enhancing clarity and detail.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Updated response time notes and observations for various tasks in the Retail, Product Marketing, and HR Onboarding scenarios.
docs: Added Sample Questions page and reference file
Thanusree-Microsoft
requested review from
Avijit-Microsoft,
Fr4nc3,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft and
marktayl1
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces significant updates to the Multi-Agent Custom Automation Engine solution, including model upgrades, improved deployment processes, enhanced documentation, and automated post-deployment configuration.
Key Changes:
- Updates Azure OpenAI model configurations from gpt-4o to gpt-4.1-mini with new capacity settings
- Adds automated post-deployment scripts for team configuration and sample data processing
- Introduces comprehensive sample workflow documentation with scenario guides
- Enhances quota checking to support multiple model types (o4-mini, gpt4.1, gpt4.1-mini)
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/agents/interactive_test_harness/reasoning_agent_interactive.py | Corrects backend path resolution by adding an additional parent directory level |
| infra/scripts/upload_team_config.py | Adds validation to handle empty string user principal IDs and includes minor whitespace change |
| infra/scripts/checkquota.sh | Updates quota checking to support three model types with configurable capacities |
| docs/images/samplequestion_1.png | Adds new screenshot image for documentation (binary file) |
| docs/SampleQuestions.md | Creates comprehensive workflow documentation with retail, marketing, and HR scenarios |
| docs/DeploymentGuide.md | Adds "Next Steps" section linking to sample questions documentation |
| .github/workflows/test-automation.yml | Updates accelerator name from "MACAE" to "MACAE v3" |
| .github/workflows/deploy.yml | Updates model configurations, adds post-deployment scripts, integrates E2E testing, and modifies notification logic |
| .github/workflows/deploy-waf.yml | Adds environment variables for multiple model capacity configurations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| CONTAINER_APP_NAME=$(az containerapp list \ | ||
| --resource-group ${{ env.RESOURCE_GROUP_NAME }} \ | ||
| --query "[0].name" -o tsv) | ||
| --query "[?starts_with(name, 'ca-') && !contains(name, 'mcp')].name" -o tsv) |
There was a problem hiding this comment.
The query filter !contains(name, 'mcp') may not work correctly if there are container apps with names that don't follow expected naming patterns. Consider using a more specific filter based on the actual naming convention used in the bicep templates (e.g., checking for a specific prefix or suffix that uniquely identifies the backend container app).
Suggested change
| --query "[?starts_with(name, 'ca-') && !contains(name, 'mcp')].name" -o tsv) | |
| --query "[?starts_with(name, 'ca-backend-')].name" -o tsv) |
Roopan-Microsoft
changed the title
Roopan-Microsoft
approved these changes
Nov 10, 2025
Prajwal-Microsoft
approved these changes
Nov 10, 2025
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
deepammi
pushed a commit
to deepammi/Multi-Agent-Custom-Automation-Engine-Solution-Accelerator
that referenced
this pull request
Dec 7, 2025
fix: merge from dev to main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces several improvements and updates to the deployment workflows, scripts, and documentation for the project. The most significant changes include enhancements to model capacity configuration, deployment workflow logic, post-deployment automation, and documentation for onboarding and usage. Below are the most important changes grouped by theme:
Deployment Workflow Updates:
.github/workflows/deploy.ymland.github/workflows/deploy-waf.ymlto support multiple models (GPT_MIN_CAPACITY,O4_MINI_MIN_CAPACITY,GPT41_MINI_MIN_CAPACITY) and changed their default values for production and WAF deployments. [1] [2] [3] [4]gpt-4.1-miniwith version2025-04-14) and increased model capacity for deployments.latest_v3.Post-Deployment Automation:
e2e-test) that runs automatically after a successful deployment and before resource cleanup.Infrastructure Script Improvements:
infra/scripts/checkquota.shto support new model capacities, clarified required/optional environment variables, and improved region/model validation logic. [1] [2] [3]infra/scripts/upload_team_config.pyby handling empty user principal IDs and request parameters more safely. [1] [2]Documentation Enhancements:
docs/DeploymentGuide.mdto guide users after deployment.docs/SampleQuestions.mdwith detailed sample workflows for Retail, Marketing, and HR teams to help users explore the solution.Miscellaneous Updates:
These changes collectively improve deployment flexibility, automation, onboarding experience, and documentation for users and developers.
Does this introduce a breaking change?
Other Information
Added new page and reference link in DeploymentGuide.md.